Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full chorus Rick Roll added to iOS contacts #208

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

RocketGod-git
Copy link
Contributor

Full chorus of Rick Roll added to the top of iOS contacts in the correct readable order.

Full chorus Rickroll to iOS contacts
Full chorus of Rick Roll added to iOS contacts in order and at the top of the contacts list
@kalanihelekunihi
Copy link
Collaborator

I would suggest refactoring this payload to use the DEFAULT_DELAY command to improve readability. This will have the same effect as your DELAY on every-other line.

You could also further optimize this by using a FUNCTION with a parameter, which would allow you to further reduce the duplicate GUI s and GUI n instances, which would further help with readability, while still letting you pass in the unique STRING data.

This payload does run as-is, so I am accepting it.
Just calling out ways that would help you write something that is a little cleaner and easier to maintain.

@kalanihelekunihi kalanihelekunihi merged commit 504adde into hak5:master Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants