Better diffs #33
Merged
Better diffs #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marysaka
approved these changes
Nov 18, 2023
|
TODO:
|
roblabla
force-pushed
the
better-diff-globals
branch
from
c0773ab to
8018ce8
Compare
roblabla
force-pushed
the
better-diff-globals
branch
from
8018ce8 to
d96b398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new kind of build, the "diff build", that uses the GNU assembler to place globals at fixed location in memory. This removes noise in the diff caused by static data being at the wrong location.
This doesn't fix all cases of static data at the wrong location (a lot of static data is auto-inserted by the compiler and we have no control over them - things like strings, or the stack cookie). But it does fix a fair amount. Furthermore, it shows a handful of cases where we write to the wrong offset, showing that our structs are likely slightly off.