Miscellanous type-based improvements #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on, I'm actually stupid. I need to fix math errors. |
|
Okay. Terribly sorry, this is what I get for doing this at 2:30 AM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the improvements in this PR come from the replacement of the
invertf()function with what it actually was,D3DXVECTOR3::operator/which calculates the reciprocal of the divisor and multiplies the vector by that. Additionally, it would appear that the cause of the mismatch inPlayer::Playerwas because ofPlayerRectnot actually usingD3DXVECTOR2, hence the erroneous presence of its constructor.