Dllbuild #52
Merged
Dllbuild #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall looks very good to me :D |
roblabla
force-pushed
the
dllbuild
branch
2 times, most recently
from
b98a96f to
33c89e0
Compare
roblabla
force-pushed
the
dllbuild
branch
8 times, most recently
from
af6c6ce to
0e122dc
Compare
For the upcoming DLL build feature, we will need to export all of the functions we reimplement. We could do this in two ways: We could either manually add __dllexport to every single function, or we could do it automatically by generating a def file from the object files that is passed to the link. We'll go with this route because god is maintaining a bunch of dllexport unsexy.
If a function is both implemented.csv and stubbed.csv, it will now stub it in generate_detours, but will avoid generating a stub (as that would create a duplicate symbol linker error). This can be useful to debug broken functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new kind of build, the
dllbuild. This generates a DLL that can be injected into the original game and replace the implemented functions with our own.It comes with several caveats that need to be documented before merging.