Add decomp status #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a cli to display decomp progress and create a status svg file.
The decomp progress now shows in the readme file
for more information, see https://pre-commit.ci
roblabla
reviewed
Feb 29, 2024
| <rect x="0" y="0" height="174" width="329" fill="white" /> | ||
|
|
||
| <text x="5" y="30" font-size="35">Decomp Progress</text> | ||
| <text x="50" y="64" font-size="16" fill="black" font-weight="bold">Functions implimented:</text> |
There was a problem hiding this comment.
Suggested change
| <text x="50" y="64" font-size="16" fill="black" font-weight="bold">Functions implimented:</text> | |
| <text x="50" y="64" font-size="16" fill="black" font-weight="bold">Functions implemented:</text> |
roblabla
reviewed
Feb 29, 2024
| <rect width="{FUNC_PROG_WIDTH}" height="26" x="5" y="81" fill="white"/> | ||
| <text x="155" y="100" font-size="16" fill="black" font-weight="bold">{FUNC_PROG_PERCENT}%</text> | ||
|
|
||
| <text x="50" y="128" font-size="16" fill="black" font-weight="bold">Bytes implimented:</text> |
There was a problem hiding this comment.
Suggested change
| <text x="50" y="128" font-size="16" fill="black" font-weight="bold">Bytes implimented:</text> | |
| <text x="50" y="128" font-size="16" fill="black" font-weight="bold">Bytes implemented:</text> |
|
LGTM! At some point I might go in and make the svgs look better :p, but so far they functionally work well. |
Merged
|
Done in #75 . Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a script that shows the decomp progress. The script will also create a
progress.svgfile in theresourcesdir. The svg is updated if theupdate_svgparam is passed to the cli.