Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG/MEDIUM: parser: fix: concurrent map writes #103

Merged
merged 1 commit into from
Mar 25, 2024
Merged

BUG/MEDIUM: parser: fix: concurrent map writes #103

merged 1 commit into from
Mar 25, 2024

Conversation

huangnauh
Copy link
Contributor 

fatal error: concurrent map writes
goroutine 18653 [running]:
github.com/haproxytech/client-native/v5/configuration.(*client).DeleteParser(0xc003a72000, {0xc00211f830, 0x24})
        /home/runner/go/pkg/mod/github.com/haproxytech/client-native/[email protected]/configuration/configuration.go:155 +0x18f
github.com/haproxytech/client-native/v5/configuration.(*Transaction).DeleteTransaction(0xc003a72000, {0xc00211f830, 0x24})
        /home/runner/go/pkg/mod/github.com/haproxytech/client-native/[email protected]/configuration/transaction.go:438 +0x12e
github.com/haproxytech/client-native/v5/configuration.(*Transaction).ErrAndDeleteTransaction(...)
        /home/runner/go/pkg/mod/github.com/haproxytech/client-native/[email protected]/configuration/transaction.go:729
github.com/haproxytech/client-native/v5/configuration.(*Transaction).HandleError(0x3?, {0xc0040d2370, 0x30}, {0xc0040d23ad, 0x8}, {0xc0040d23c2, 0x34}, {0xc00211f830, 0x24}, 0x1, ...)

@mjuraga
Copy link
Collaborator

mjuraga commented Jan 22, 2024

Thanks for the commit, can you just change your commit message to adhere to our Contributing guide, example commit message would be: BUG/MEDIUM: parser: fix: concurrent map writes

@huangnauh
Copy link
Contributor Author

Thanks for the commit, can you just change your commit message to adhere to our Contributing guide, example commit message would be: BUG/MEDIUM: parser: fix: concurrent map writes

sorry for the late reply

@huangnauh huangnauh changed the title fix: concurrent map writes BUG/MEDIUM: parser: fix: concurrent map writes Mar 1, 2024
@mjuraga mjuraga merged commit 6b9eb3e into haproxytech:master Mar 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huangnauh @mjuraga