MINOR: Support PodMonitor as alternative to ServiceMonitor #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Hossner <[email protected]>
|
Congrats, PR looks clean and simple. I'll merge and run through CI/CD pipelines. |
|
Hi, thanks for the quick merge. I made a mistake in the tests though: The contents of ci/deployment-podmonitor-values.yaml are wrong. I tried to fix this but you were too quick :-D |
dkorunic
added a commit
that referenced
this pull request
Jan 10, 2025
Changes in kubernetes-ingress: - Support PodMonitor as alternative to ServiceMonitor (#271) - Use correct values for PodMonitor test (#272) - Support to specify HPA behavior (#274) - Make controller.podAnnotations templatable (#276) - Fix controller.podAnnotations not being templatable in every location (#277) - Make controller.config templatable (#279) Signed-off-by: Dinko Korunic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #270