Files

[Azeirah]

There it is, file loading support for Moonchild.

Right now, you can open a file using
node server.js [file.js], any open instance of moonchild will then receive this file. Saving has been implemented, but it has been disabled to prevent potential issues, since it hasn't been tested at all, don't want to overwrite random files...

On the client side, channel.js, fileloader.js and util.js were added. These are fairly clean files. On the server side, I've bruteforced websockets into the code. Merging is not recommended before that is cleaned up or moved to a separate file.

I've also cleaned up some bits of the code, added some semicolons, refactored some ternary statements to if statements etc...

Also, I saw you were using, it's a bit cleaner to fix that up:

if (bla != null) {...}
// you can use
if (!bla) {...}

var a;
a === undefined; // true
a === null; // false
// by default, variables are "undefined", not "null"

Is it possible to request to merge this into a branch on cdglabs? Because this definitely shouldn't get merged into master right now

[pdubroy]

Thanks for writing this! I will give it a try and a closer look tomorrow.

About the style: a couple of the files were originally written in CoffeeScript, which is why some things are different from typical JS style -- they are mostly just what the CS compiler produces. The reason it produces x != null is because !x will be true if x is 0 or '', whereas x != null checks only for null and undefined.

If this isn't ready to merge yet, we might as well keep it in your branch -- I'm not sure what the advantage would be of merging it into a branch in the main repo. I think the best thing to do is to get the smallest possible piece working -- say, file loading -- and get that merged into master.

[Azeirah]

Alright, I split the saving and the websockets part up into two files that get included by server.js. Loading and saving files is working on my system, I think it's ready to get merged.

[pdubroy]

Hey Martijn, thanks a lot for this! I'm sorry that I haven't had a chance to give it a thorough review yet. We're trying to finish a release of another project we're working on. I hope I can take a look tomorrow, but I might not get to it until early next week.

[pdubroy]

I'm really sorry I haven't gotten around to merging this. Would it be possible to split this up into a few different pull requests? That would make it easier for me to review. At the length it is now, it's a bit too much to handle at once.

In particular, it would be nice to have the style changes in a separate PR, and maybe loading and saving in separate PRs (if that makes sense).

[Azeirah]

Oh wow, looking at the changed files, that's a lot more than I remember changing, most changes are small insignificant style changes though, some done automatically by Sublime (removing trailing whitespace and adding enter at each file). I'll try to separate these changes from the actual fileloading.

As a quick synopsis, what I did was add a small abstraction over websockets that works like this:

// on the server
channel.send("someEvent", {value: "hi", stuff: 14, whatever: "yes please"});

// on the client
channel.on("someEvent", function (data) {
  // do whatever
});

These are implemented separately for the server and for the client. The client one is in /lib/channel.js, the server one is in server/channel.js.

Then, the actual fileloading is done by server/fileLoader.js and editor/loadFile.js (why did I not name them the same? I don't know!). I've written them in such a way that they can be loaded as a plugin.