[WIP] Add docker development environment

[doodyparizada]

run docker-compose up and you have a full development environment in docker.

@oryband

There is also an automated build on docker hub: https://hub.docker.com/r/doodyparizada/open-knesset/

[noamelf]

So cool!
On Nov 17, 2015 10:19 PM, "Doody Parizada" [email protected] wrote:

run docker-compose up and you have a full development environment in
docker.

@oryband https://github.com/oryband

You can view, comment on, or merge this pull request online at:

#424
Commit Summary

• Add docker development environment

File Changes

• A Dockerfile
  https://github.com/hasadna/Open-Knesset/pull/424/files#diff-0 (39)
• M README.rst
  https://github.com/hasadna/Open-Knesset/pull/424/files#diff-1 (10)
• A docker-compose.yml
  https://github.com/hasadna/Open-Knesset/pull/424/files#diff-2 (7)
• A docker/docker_settings.py
  https://github.com/hasadna/Open-Knesset/pull/424/files#diff-3 (20)
• A docker/entrypoint.sh
  https://github.com/hasadna/Open-Knesset/pull/424/files#diff-4 (6)

Patch Links:

• https://github.com/hasadna/Open-Knesset/pull/424.patch
• https://github.com/hasadna/Open-Knesset/pull/424.diff

—
Reply to this email directly or view it on GitHub
#424.

[oryband]

MAINTAINER Doody Parizada <doody.parizada @ gmail.com>

[oryband]

sorry for being strict, this is the first introduction to docker in hasadna so we better get this right

[OriHoch]

• db should be in /opt/knesset - so users can change it
• download of dev.db should be done only if it doesn't already exist
• should be done in entrypoint

[habeanf]

@oryband While we're here, can we get the docker environment to use postgres instead of sqlite? We've been wanting to be pg-only for a while, its a bit of a headache to support both. I can help with the pg setup next week.

[noamelf]

Did you encounter any problems with sqlite?

On Wed, Nov 25, 2015 at 12:01 PM, Amir More [email protected]
wrote:

@oryband https://github.com/oryband While we're here, can we get the
docker environment to use postgres instead of sqlite? We've been wanting to
be pg-only for a while, its a bit of a headache to support both. I can help
with the pg setup next week.

—
Reply to this email directly or view it on GitHub
#424 (comment).

,Noam Elfanbaum
972-54-555-1680+

[habeanf]

It's not that I encountered problems, as much as it requires some code to be written twice, so for some parts of oknesset the developer already needs to install postgres anyhow.
Eventually, we'll want to rely on more of postgres' capabilities for performance/efficiency (e.g. analytic/window functions, non-trivial indexes, partitioning, etc). Historically we enabled sqlite for ease of development and environment setup. If we have a docker setup, we might as well have it run on postgres and save the extra headache.

[noamelf]

That's a good example you sent!
Cool, I like the idea.

On Wed, Nov 25, 2015 at 12:40 PM, Amir More [email protected]
wrote:

It's not that I encountered problems, as much as it requires some code to
be written twice
https://github.com/hasadna/Open-Knesset/blob/master/agendas/models.py#L51,
so for some parts of the oknesset the developer already needs to install
postgres anyhow.
Eventually, we'll want to rely on more of postgres' capabilities for
performance/efficiency (e.g. analytic/window functions, non-trivial
indexes, partitioning, etc). Historically we enabled sqlite for ease of
development and environment setup. If we have a docker setup, we might as
well have it run on postgres and save the extra headache.

—
Reply to this email directly or view it on GitHub
#424 (comment).

,Noam Elfanbaum
972-54-555-1680+

[oryband]

@habeanf

@oryband While we're here, can we get the docker environment to use postgres instead of sqlite? We've been wanting to be pg-only for a while, its a bit of a headache to support both. I can help with the pg setup next week.

you should probably use a stub postgres docker image, and docker-compose with fixtures. this will allow to connect an ok and postgres images together easily. @doodyparizada can help, i guess.

[oryband]

why not vivid?

[oryband]

single backquotes

[OriHoch]

@doodyparizada - I would like to merge it, do you intend to continue working on it sometime soon?

[oryband]

@doodyparizada ?

[oryband]

@OriHoch i can help with this as well if you'd like, let's talk today

[OriHoch]

hey, anyone working on this?

If not, @uda - you can take it..

[OriHoch]

this issue might be related to #527

[oryband]

@OriHoch i'll also be at the hasadna today, feel free to talk to me if you need docker help