Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: edit test for youtube modal in 'report a bug' #1002

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

YaelChen
Copy link
Collaborator

@YaelChen YaelChen commented Jan 8, 2025

Description

Edited the existing test with expectations for the iframe to be visible and to have the correct src.
also wanted to see if there's a problem with the docker build.

@YaelChen YaelChen requested a review from NoamGaash as a code owner January 8, 2025 11:29
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👏
Can you remove the redundant comments?

remove comments
@YaelChen
Copy link
Collaborator Author

Great! 👏 Can you remove the redundant comments?

Woah, that's weird, I guess it was uploaded by mistake between the pushes, I don't have them anymore.
Deleted it here directly on Github.

Hope to be focused back on the project soon :)

@YaelChen YaelChen merged commit 08a8e66 into main Jan 23, 2025
16 of 17 checks passed
@YaelChen YaelChen deleted the bugReportYouTubeModal branch January 23, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants