Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test for 'about' YouTube modal #1003

Merged
merged 5 commits into from
Jan 13, 2025
Merged

test: fix test for 'about' YouTube modal #1003

merged 5 commits into from
Jan 13, 2025

Conversation

YaelChen
Copy link
Collaborator

@YaelChen YaelChen commented Jan 9, 2025

Description

Use the toHaveAttribute and isVisible attr.

@YaelChen YaelChen requested a review from NoamGaash as a code owner January 9, 2025 07:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Preview: https://s3.amazonaws.com/noam-gaash.co.il/12685784675/open-bus/275/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/12685784675/open-bus/275/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/12685784675/open-bus/5933e5d968070465492bee971b681cba01d7eef9/test-results/index.html'

NoamGaash
NoamGaash approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! 👏

@YaelChen YaelChen merged commit c80089f into main Jan 13, 2025
17 of 18 checks passed
@YaelChen YaelChen deleted the aboutYouTubeModal branch January 13, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YaelChen @NoamGaash