Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#232 #293

Closed
wants to merge 2 commits into from
Closed

#232 #293

wants to merge 2 commits into from

Conversation

eyalyehia
Copy link
Contributor

add charts to storybook

@eyalyehia eyalyehia requested a review from NoamGaash as a code owner December 13, 2023 11:10
@NoamGaash NoamGaash changed the base branch from main to main2 December 13, 2023 12:16
@NoamGaash NoamGaash changed the base branch from main2 to main December 13, 2023 12:17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it on purpose? I think it could be removed

"@playwright/test": "^1.37.1",
"@playwright/test": "^1.40.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! but next time, such things require separate PR.


type Story = StoryObj<typeof meta>

const operatorsPT: Entry[] = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since stories are just demos, the array can be shorter (you don't have to use real data)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that's added by accident and can be removed

@eyalyehia eyalyehia closed this by deleting the head repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants