Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add DisplayGapsPercentage to storybook #896

Merged
merged 1 commit into from
Oct 23, 2024
Merged

docs: add DisplayGapsPercentage to storybook #896

merged 1 commit into from
Oct 23, 2024

Conversation

griseduardo
Copy link
Collaborator

@griseduardo griseduardo commented Oct 22, 2024 •
edited
Loading

Description

Add DisplayGapsPercentage in storybook
Show different cases in documentation:

  • When gapsPercentage is lower than decentPercentage
  • When gapsPercentage is between decentPercentage and terriblePercentage
  • When gapsPercentage is higher than terriblePercentage

It relates to: #892

screenshots

gaps-percentage

@griseduardo griseduardo self-assigned this Oct 22, 2024
@griseduardo griseduardo force-pushed the docs/add-storybook-display-gaps-percentage branch from 2a72b6b to 8c4ae34 Compare October 22, 2024 12:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/11460306118/open-bus/111/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/11460306118/open-bus/111/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/11460306118/open-bus/8c4ae3449de987b4a60a1f8626801801496fe1d1/test-results/index.html'

@griseduardo griseduardo mentioned this pull request Oct 22, 2024
Open
NoamGaash
NoamGaash approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Thanks for your contribution 👏

@griseduardo griseduardo merged commit cf4e211 into main Oct 23, 2024
16 of 18 checks passed
@griseduardo griseduardo deleted the docs/add-storybook-display-gaps-percentage branch October 23, 2024 12:24
@NoamGaash
Copy link
Member

Thanks for making this contribution!
@all-contributors please add @griseduardo to code

@allcontributors allcontributors bot mentioned this pull request Oct 24, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@NoamGaash

I've put up a pull request to add @griseduardo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees

@griseduardo griseduardo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@griseduardo @NoamGaash