Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve donation button accessibility #952

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor: improve donation button accessibility #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1464598
improve_accessibility
chaniBenziman Nov 27, 2024
b718893
Merge branch 'main' into Improve_accessibility
chaniBenziman Nov 27, 2024
a65616f
Merge branch 'main' into Improve_accessibility
chaniBenziman Nov 27, 2024
6725db8
change_arrow
chaniBenziman Dec 4, 2024
f624fcf
Merge branch 'Improve_accessibility' of https://github.com/hasadna/op…
chaniBenziman Dec 4, 2024
445e030
Merge branch 'main' into Improve_accessibility
chaniBenziman Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/pages/DonateModal/DonateModal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
.donate-button {
display: inline-block;
background-color: #007BFF;
color: white;
padding: 10px 20px;
font-size: 16px;
font-family: Arial, sans-serif;
text-decoration: none;
border-radius: 5px;
transition: background-color 0.3s;
}

.donate-button:hover {
background-color: #0056b3;
}

16 changes: 9 additions & 7 deletions src/pages/DonateModal/DonateModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React from 'react'
import { Box, Grid, Modal, Typography, useMediaQuery } from '@mui/material'
import i18n from 'src/locale/allTranslations'
import './DonateModal.scss'

interface DonateModalProps {
isVisible: boolean
Expand Down Expand Up @@ -67,13 +68,14 @@
width={'90%'}
style={{ maxWidth: '420px' }}
/>
<img
width={'90%'}
src="https://www.hasadna.org.il/wp-content/uploads/2018/08/button-300x73.png"
alt="תרום עכשיו"
// style={{ margin: shouldImgCollapse ? 'auto' : '', display: 'block' }}
style={{ display: 'block', maxWidth: '300px' }}
/>
<a
href="https://www.jgive.com/new/he/ils/donation-targets/3268"
target="_blank"
rel="noreferrer"
className="donate-button"

Check failure on line 75 in src/pages/DonateModal/DonateModal.tsx

View workflow job for this annotation

GitHub Actions / local-tests 

Delete `⏎················`
>
לתרום לסדנא ←

Check failure on line 77 in src/pages/DonateModal/DonateModal.tsx

View workflow job for this annotation

GitHub Actions / local-tests 

Delete `·`
</a>
</a>
</Typography>
</Grid>
Expand Down
Loading