Restrict concurrent password hashes #5437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
commented
Jan 20, 2025
| ### Bug fixes | ||
|
|
||
| * Fix an issue where, when starting a session, the connection limit always displays 0. | ||
| ([PR](https://github.com/hashicorp/boundary/pull/5396)). |
There was a problem hiding this comment.
There were two "Bug Fixes" sections in the changelog under "Next", so I moved this one up to the one above.
johanbrandhorst
commented
Jan 20, 2025
johanbrandhorst
force-pushed
the
jbrandhorst-restrict-concurrent-hashes
branch
from
23f6166 to
1bcd202
Compare
johanbrandhorst
force-pushed
the
jbrandhorst-restrict-concurrent-hashes
branch
2 times, most recently
from
eba8590 to
d202821
Compare
tmessi
reviewed
Jan 21, 2025
johanbrandhorst
force-pushed
the
jbrandhorst-restrict-concurrent-hashes
branch
4 times, most recently
from
e5dc552 to
392fc52
Compare
The resizable pool wraps the permit pool with a mutex to allow it to be resized at runtime.
The default concurrency limit is 1, and it can be set using the SetHashingPermits function.
The new concurrent_password_hash_workers configuration value can be used to loosen the constraints on the userpass auth method hashing operation.
Sets the password hashing concurrency constraints on startup and config reload.
johanbrandhorst
force-pushed
the
jbrandhorst-restrict-concurrent-hashes
branch
from
392fc52 to
5e23cd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/auth/password: add resizable pool
The resizable pool wraps the permit pool with a mutex
to allow it to be resized at runtime.
internal/auth/password: add concurrency limit
The default concurrency limit is 1, and it can be
set using the SetHashingPermits function.
internal/cmd/config: allow configuring hashing limits
The new concurrent_password_hash_workers configuration
value can be used to loosen the constraints on the
password auth method hashing operation.
internal/cmd: set password hashing constraints
Sets the password hashing concurrency constraints on
startup and config reload.
CHANGELOG: add notice about password concurrency limit