Add condition "nodes" that triggers a task everytime a Consul node is updated

Makefile

@@ -45,7 +45,7 @@ test:
 test-integration:
 	@echo "==> Testing ${NAME} (test suite & integration)"
 	@go test -count=1 -timeout=80s -tags=integration -cover ./... ${TESTARGS}
-.PHONY: test-all
+.PHONY: test-integration
 
 # test-e2e runs e2e tests
 test-e2e: dev

client/terraform_cli_test.go

@@ -350,7 +350,7 @@ module for task "test-workspace" is missing the "catalog_services" variable, add
 			}
 		}
 	]
-}`,	// Terraform v0.13/v0.14 output
+}`, // Terraform v0.13/v0.14 output
 		},
 		{
 			"warning",

config/condition.go

@@ -41,6 +41,8 @@ func isConditionNil(c ConditionConfig) bool {
 		result = v == nil
 	case *CatalogServicesConditionConfig:
 		result = v == nil
+	case *NodesConditionConfig:
+		result = v == nil
 	default:
 		return c == nil || reflect.ValueOf(c).IsNil()
 	}
@@ -84,6 +86,10 @@ func conditionToTypeFunc() mapstructure.DecodeHookFunc {
 			var config ServicesConditionConfig
 			return decodeConditionToType(c, &config)
 		}
+		if c, ok := conditions[nodesConditionTypes]; ok {
+			var config NodesConditionConfig
+			return decodeConditionToType(c, &config)
+		}
 
 		return nil, fmt.Errorf("unsupported condition type: %v", data)
 	}

config/condition_nodes.go

@@ -0,0 +1,88 @@
+package config
+
+import "fmt"
+
+const nodesConditionTypes = "nodes"
+
+type NodesConditionConfig struct {
+	Datacenter *string `mapstructure:"datacenter"`
+
+	services []string
+}
+
+func (n *NodesConditionConfig) Copy() ConditionConfig {
+	if n == nil {
+		return nil
+	}
+
+	var o NodesConditionConfig
+	o.Datacenter = n.Datacenter
+	copy(o.services, n.services)
+
+	return &o
+}
+
+func (n *NodesConditionConfig) Merge(o ConditionConfig) ConditionConfig {
+	if n == nil {
+		if isConditionNil(o) {
+			return nil
+		}
+		return o.Copy()
+	}
+
+	if isConditionNil(o) {
+		return n.Copy()
+	}
+
+	r := n.Copy()
+	o2, ok := o.(*NodesConditionConfig)
+	if !ok {
+		return r
+	}
+
+	r2 := r.(*NodesConditionConfig)
+
+	if o2.Datacenter != nil {
+		r2.Datacenter = StringCopy(o2.Datacenter)
+	}
+
+	r2.services = append(r2.services, o2.services...)
+
+	return r2
+}
+
+func (n *NodesConditionConfig) Finalize(services []string) {
+	if n == nil {
+		return
+	}
+
+	if n.Datacenter == nil {
+		n.Datacenter = String("")
+	}
+
+	n.services = services
+}
+
+func (n *NodesConditionConfig) Validate() error {
+	if n == nil {
+		return nil
+	}
+
+	if len(n.services) != 0 {
+		return fmt.Errorf("task.services cannot be set when using condition %q", nodesConditionTypes)
+	}
+
+	return nil
+}
+
+func (n *NodesConditionConfig) GoString() string {
+	if n == nil {
+		return "(*NodesConditionConfig)(nil)"
+	}
+
+	return fmt.Sprintf("&NodesConditionConfig{"+
+		"Datacenter:%s, "+
+		"}",
+		StringVal(n.Datacenter),
+	)
+}

config/condition_nodes_test.go

@@ -0,0 +1,165 @@
+package config
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestNodesConditionConfig_Copy(t *testing.T) {
+	cases := []struct {
+		name string
+		a    *NodesConditionConfig
+	}{
+		{
+			"nil",
+			nil,
+		},
+		{
+			"empty",
+			&NodesConditionConfig{},
+		},
+		{
+			"fully_configured",
+			&NodesConditionConfig{
+				Datacenter: String("dc2"),
+			},
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			r := tc.a.Copy()
+			if tc.a == nil {
+				// returned nil interface has nil type, which is unequal to tc.a
+				assert.Nil(t, r)
+			} else {
+				assert.Equal(t, tc.a, r)
+			}
+		})
+	}
+}
+
+func TestNodesConditionConfig_Merge(t *testing.T) {
+	cases := []struct {
+		name string
+		a    *NodesConditionConfig
+		b    *NodesConditionConfig
+		r    *NodesConditionConfig
+	}{
+		{
+			"nil_a",
+			nil,
+			&NodesConditionConfig{},
+			&NodesConditionConfig{},
+		},
+		{
+			"nil_b",
+			&NodesConditionConfig{},
+			nil,
+			&NodesConditionConfig{},
+		},
+		{
+			"nil_both",
+			nil,
+			nil,
+			nil,
+		},
+		{
+			"empty",
+			&NodesConditionConfig{},
+			&NodesConditionConfig{},
+			&NodesConditionConfig{},
+		},
+		{
+			"datacenter_overrides",
+			&NodesConditionConfig{Datacenter: String("same")},
+			&NodesConditionConfig{Datacenter: String("different")},
+			&NodesConditionConfig{Datacenter: String("different")},
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			r := tc.a.Merge(tc.b)
+			if tc.r == nil {
+				// returned nil interface has nil type, which is unequal to tc.r
+				assert.Nil(t, r)
+			} else {
+				assert.Equal(t, tc.r, r)
+			}
+		})
+	}
+}
+
+func TestNodesConditionConfig_Finalize(t *testing.T) {
+	cases := []struct {
+		name string
+		s    []string
+		i    *NodesConditionConfig
+		r    *NodesConditionConfig
+	}{
+		{
+			"empty",
+			[]string{},
+			&NodesConditionConfig{},
+			&NodesConditionConfig{
+				Datacenter: String(""),
+				services:   []string{},
+			},
+		},
+		{
+			"pass_in_services",
+			[]string{"api"},
+			&NodesConditionConfig{},
+			&NodesConditionConfig{
+				Datacenter: String(""),
+				services:   []string{"api"},
+			},
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			tc.i.Finalize(tc.s)
+			assert.Equal(t, tc.r, tc.i)
+		})
+	}
+}
+
+func TestNodesConditionConfig_Validate(t *testing.T) {
+	cases := []struct {
+		name      string
+		expectErr bool
+		services  []string
+	}{
+		{
+			"nil",
+			false,
+			nil,
+		},
+		{
+			"empty",
+			false,
+			[]string{},
+		},
+		{
+			"services set",
+			true,
+			[]string{"api"},
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			n := &NodesConditionConfig{}
+			n.Finalize(tc.services)
+			err := n.Validate()
+			if tc.expectErr {
+				assert.Error(t, err)
+			} else {
+				assert.NoError(t, err)
+			}
+		})
+	}
+}

config/condition_test.go

@@ -141,6 +141,58 @@ task {
 		nonexistent_field = true
 	}
 }`,
+		},
+		{
+			"nodes: empty",
+			false,
+			&NodesConditionConfig{
+				Datacenter: String(""),
+				services:   []string{},
+			},
+			"config.hcl",
+			`
+task {
+	name = "condition_task"
+	source = "..."
+	services = []
+	condition "nodes" {}
+}
+`,
+		},
+		{
+			"nodes: happy path",
+			false,
+			&NodesConditionConfig{
+				Datacenter: String("dc2"),
+				services:   []string{},
+			},
+			"config.hcl",
+			`
+task {
+	name = "condition_task"
+	source = "..."
+	services = []
+	condition "nodes" {
+		datacenter = "dc2"
+	}
+}
+`,
+		},
+		{
+			"nodes: unsupported field",
+			true,
+			nil,
+			"config.hcl",
+			`
+task {
+	name = "condition_task"
+	source = "..."
+	services = []
+	condition "nodes" {
+		nonexistent_field = true
+	}
+}
+`,
 		},
 		{
 			"error: two conditions",

driver/task.go

@@ -320,6 +320,10 @@ func (t *Task) configureRootModuleInput(input *tftmpl.RootModuleInputData) {
 		condition = &tftmpl.ServicesCondition{
 			Regexp: *v.Regexp,
 		}
+	case *config.NodesConditionConfig:
+		condition = &tftmpl.NodesCondition{
+			Datacenter: *v.Datacenter,
+		}
 	default:
 		// expected only for test scenarios
 		log.Printf("[WARN] (driver.terraform) task '%s' condition config unset."+