Fix syslog enabled value #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lornasong
requested review from
a team and
wilkermichael
and removed request for
a team
wilkermichael
approved these changes
Apr 26, 2022
|
@lornasong looks good, good catch |
Context: syslog should be automatically enabled if other fields (e.g. facility or name) values are provided. This is documented in CTS Issue: syslog enabled field has to be specifically set to true. Otherwise it is false even though other config fields are provided. This was caused by the default was set to enabled=false. When CTS builds the config, the user-provided config is merged with the default config. If the user left enabled unconfigured, it would merge with the default enabled=false. This results in enabled being set to false in a way that looks as though the user set enabled to false. Related: #812
lornasong
force-pushed
the
syslog-enable
branch
from
dd49eb7 to
dbd13fc
Compare
|
no changes, just rebase latest on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: syslog should be automatically enabled if other fields (e.g. facility
or name) values are provided. This is documented in CTS
Issue: syslog enabled field has to be specifically set to true. Otherwise it is
false even though other config fields are provided.
This was caused by the default was set to enabled=false. When CTS builds the
config, the user-provided config is merged with the default config. If the user
left enabled unconfigured, it would merge with the default enabled=false. This
results in enabled being set to false in a way that looks as though the user set
enabled to false.
Related: #812