Update go-discover to support ECS discovery

[fdr2]

Description

Go-Discover now supports ECS container instance discovery. This change updates the go-discover dependency and corresponding documentation outlining new options.

Testing & Reproduction steps

test/load-ecs has been added with load testing capabilities for 25 vus at 10 minutes. see test/load-ecs/README.md for more info. test/load-ecs has been moved to terraform-aws-consul-ecs PR:139

Links

Issue: GH-6802
Dependency: PR-197

PR Checklist

• updated test coverage
• external facing docs updated
• not a security concern

[Amier3]

Hey @fdr2

Thanks for making this, we're in a bit of crunch-time right now gearing up for the next consul release, so i'd expect us to get to this after the release in early august.

[fdr2]

Sounds great @Amier3 thanks for the feedback. I'm hoping to investigate the performance concerns raised regarding efs, currently working out load tests with k6 and datadog in a similar fashion to the ec2 load test

[trujillo-adam]

Added some suggestions for the docs -- mostly edits for consistency with the style guide.

[fdr2]

Added some suggestions for the docs -- mostly edits for consistency with the style guide.

Thank you! These are excellent improvements. I've incorporated them all.

[pglass]

Hi @fdr2, this is great work! Thank you.

We'd prefer to put the load test code for ECS into our ECS-focused repository: https://github.com/hashicorp/terraform-aws-consul-ecs/

The path forward I'd suggest is:

1. Trim down this PR to only include the version bump of the go-discover dependency and the associated documentation changes in the website directory. This should enable us to get the change in prior to our upcoming code freeze for the next release of Consul.
2. Then, open PR(s) to https://github.com/hashicorp/terraform-aws-consul-ecs/ containing the load test code, and add me as a reviewer. I'd like to potentially extract your Terraform code for deploying the Consul servers on ECS into a new Terraform module there, and include your load test code over there as well.

I know this is a lot to ask, so thanks for your patience 🙂. Let me know if you have any questions.

[pglass]

Hi @fdr2, thanks for your patience on this!

Can you please add a changelog entry that indicates the support for ECS discovery? There are instructions here for including a changelog entry

We were in code freeze at the time, so I wasn't able to include this in Consul 1.14.0, but this can go out in the next patch release(s) of 1.12, 1.13, and 1.14 after this is merged.