Code editor additional languages #2684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashibot-hds
added
packages/components
docs-website
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shleewhite
reviewed
Feb 5, 2025
| Ruby = 'ruby', | ||
| Shell = 'shell', | ||
| Go = 'go', | ||
| Hcl = 'hcl', | ||
| Javascript = 'javascript', |
There was a problem hiding this comment.
Nit: should it be JavaScript?
| "@hashicorp/design-system-components": minor | ||
| --- | ||
|
|
||
| hds-code-editor: Add language syntax highlighting suport for JavaScript and Rego |
There was a problem hiding this comment.
Nit: should we include that theres a new dep @codemirror/lang-javascript?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR adds syntax highlighting support for JavaScript and Rego to the
hds-code-editormodifier.🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira tickets:
HDS-4452
HDS-4469
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.