Fix support for getting single files from GitHub (v2) #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikkfir
changed the title
arikkfir
force-pushed
the
support_getfile_from_github_v2
branch
from
e03eae6 to
e7578c2
Compare
arikkfir
changed the title
arikkfir
force-pushed
the
support_getfile_from_github_v2
branch
2 times, most recently
from
e7578c2 to
635e41d
Compare
|
Rebased branch to include new commits since April 2022 - and the change is still relevant and needed. |
This currently fails for GitHub (and possibly other Git repositories) because there is an assumption in the "client.go" file that the "subDir" segment is always a directory. However, for this URL: https://github.com/owner/repo/subdir/file.txt The "subDir" variable would actually be a file ("subdir/file.txt") and hence the client should use "copyFile" rather than "copyDir" when copying the "subDir" to the final destination. This change fixes that to check whether the "subDir" variable is a file or a directory, and appropriately uses "copyDir" or "copyFile". It also returns the single file in the "GetResult" object, if indeed a single file was requested. Tests attached.
arikkfir
force-pushed
the
support_getfile_from_github_v2
branch
from
635e41d to
66abd65
Compare
|
Rebased this branch off of the |
|
Any news? Still facing this issue... :/ |
|
@arikkfir sorry for not being able to get to this sooner. Thank you for the contribution. I've assigned the change to myself for review. |
|
hello, is there any update to this, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently fails for GitHub (and possibly other Git repositories) because there is an assumption in the
client.gofile that thesubDirsegment is always a directory.However, for the URL "https://github.com/owner/repo/subdir/file.txt[](https://github.com/arikkfir)" the "subDir" variable would actually be a file (
subdir/file.txt) and hence the client should usecopyFilerather thancopyDirwhen copying thesubDirto the final destination.This change fixes that to check whether the "subDir" variable is a file or a directory, and appropriately uses
copyDirorcopyFile. It also returns the single file in the "GetResult" object, if indeed a single file was requested.Tests attached.
This fixes #98