A dedicated variable at nomad/ui/defaults #24868
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
20482-ui-preferences-variable
branch
from
dfb5f61 to
4818838
Compare
philrenaud
commented
Jan 20, 2025
| ]; | ||
|
|
||
| async establishUIDefaults() { | ||
| // // First, check to see if there are localStorage properties set for each of the defaults. |
There was a problem hiding this comment.
Probably a premature optimization
philrenaud
commented
Jan 20, 2025
|
|
||
| async fetchVariableDefaults() { | ||
| try { | ||
| // if (this.can.can('read variable', 'nomad/ui/defaults', '*')) { // TODO: is wildcard correctly handled by "can"? |
There was a problem hiding this comment.
Tested without can ability checks and this fails gracefully. Can probably remove the condition.
philrenaud
force-pushed
the
20482-ui-preferences-variable
branch
from
5af4026 to
a9e4175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a variable at
nomad/ui/defaultsto override agent config ui defaults, but can still be overriden by localStorage and queryParams.A nice middle ground between "Everybody gets this because it's part of the agent configuration" and "Only you, in this browser, get it", because you can turn variable access on/off via ACL policy definitions, with the added benefit of "You can change this without having to restart your server", which is a problem the agent UI config block has.