Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vault token warning from 1.9->1.10 #24884

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

schmichael
Copy link
Member

Fixes #24847

We forgot to update the log line when we bumped the deprecation date: https://developer.hashicorp.com/nomad/docs/integrations/vault/acl#authentication-without-workload-identity-legacy

Description

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@schmichael schmichael added backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent labels Jan 17, 2025
@schmichael schmichael requested review from a team as code owners January 17, 2025 00:39
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross added backport/1.9.x backport to 1.9.x release line and removed backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent labels Jan 17, 2025
@schmichael schmichael merged commit 63dacd2 into main Jan 17, 2025
42 checks passed
@schmichael schmichael deleted the b-vault-deprecation branch January 17, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Deprecation Warning Messages in Nomad 1.9.x for Legacy Authentication
3 participants