Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remote task execution code #24909

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Conversation

mismithhisler
Copy link
Member

@mismithhisler mismithhisler commented Jan 21, 2025

Description

Removes remote task driver code, which is a followup to PR #24720 where it was decided this deprecated code should be removed (link to comment).

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. I think structs.TaskHandle can be removed entirely like you did with the RemoteTasks field. There's an api package version as well.

To make things more confusing, there's also a plugins/drivers/task_handle.go which we need to keep! It's a superset of structs.TaskHandle that the Client still needs. Naming things is hard ok? 😬

jrasell
jrasell previously approved these changes Jan 23, 2025
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this.

Do we want to add changelog and an upgrade notice for this too?

@mismithhisler mismithhisler merged commit 47c14dd into main Jan 29, 2025
32 checks passed
@mismithhisler mismithhisler deleted the f-remove-remote-task-execution branch January 29, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants