-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prop assignment based on Props.ts #44
base: main
Are you sure you want to change the base?
Conversation
}, | ||
} | ||
|
||
export type { Props } from './index' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an example of just using Props from the component itself, rather than the contrived example in Button, where the Props are declared there :)
@ztanner Awesome! I wonder if it would be possible to automatically extract props from the component definition itself, instead of having to export it from the The thought being that we could make the entire
|
Ahh, that's a much simpler API! I'll get this loaded in |
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
Bryce Kalow seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
TODO: Some API cleanup & remove some ts-ignores