Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade go version to 1.22 and use tmccombs/hcl2json #3814

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mutahhir
Copy link
Member

Related issue

Fixes #3793

Description

An effort to solve the problems @uluzox was having with their PR by upgrading the go version across all our examples. While the main reason for doing this PR was to see if we can reuse tmccombs/hcl2json instead of our fork, I had to fix a bunch of go examples along the way.

The reason for switching back is written in detail within @uluzox's PR: #3797.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir requested a review from a team as a code owner January 30, 2025 11:42
@mutahhir mutahhir requested review from ansgarm and DanielMSchmidt and removed request for a team January 30, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COMPONENT: use latest version of tmccombs/hcl2json
1 participant