Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a max_crl_size parameter to CRL config #28654

Merged
merged 12 commits into from
Oct 9, 2024
Merged

Conversation

sgmiller
Copy link
Collaborator

@sgmiller sgmiller commented Oct 9, 2024

Description

If set or the default 100k, CRL building will fail if there are more than
that many entries in the CRL. It will also warn when within 10% of the
limit.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@sgmiller sgmiller requested a review from a team as a code owner October 9, 2024 16:58
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Oct 9, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have left a suggestion.

Not approving right away to check whether there are docs that need to be updated.

builtin/logical/pki/path_config_crl.go Outdated Show resolved Hide resolved
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, nothing preventing merging after api-docs are updated.

builtin/logical/pki/path_config_crl.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_config_crl.go Outdated Show resolved Hide resolved
@sgmiller sgmiller requested a review from a team as a code owner October 9, 2024 18:28
@sgmiller sgmiller added this to the 1.19.0-rc milestone Oct 9, 2024
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just need to update the api-docs with the new field name.

website/content/api-docs/secret/pki/index.mdx Outdated Show resolved Hide resolved
website/content/api-docs/secret/pki/index.mdx Outdated Show resolved Hide resolved
website/content/api-docs/secret/pki/index.mdx Outdated Show resolved Hide resolved
@sgmiller sgmiller requested a review from stevendpclark October 9, 2024 20:08
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sgmiller sgmiller enabled auto-merge (squash) October 9, 2024 21:27
@sgmiller sgmiller merged commit 004dfc4 into main Oct 9, 2024
91 checks passed
@sgmiller sgmiller deleted the sgm/vault-22664/max-crl-size branch October 9, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants