Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for flakes in raft removed tests #29270

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

miagilepner
Copy link
Contributor

Description

Updates the tests to fix occasional flakes.

Adds a helper method for an enterprise test. Enterprise PR: https://github.com/hashicorp/vault-enterprise/pull/7199

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@miagilepner miagilepner added this to the 1.19.0-rc milestone Jan 2, 2025
@miagilepner miagilepner requested a review from a team as a code owner January 2, 2025 12:43
@miagilepner miagilepner requested a review from scellef January 2, 2025 12:43
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

CI Results:
All required Go tests succeeded but failures were detected ⚠️
Failures:

Test Type Package Test Logs
race vault/external_tests/raftha TestRaftHACluster_Removed_ReAdd view test results

Copy link

github-actions bot commented Jan 2, 2025

Build Results:
All builds succeeded! ✅

@miagilepner miagilepner force-pushed the miagilepner/flaky-fixes branch from 38be91f to 22cf923 Compare January 6, 2025 10:32
Copy link
Contributor

@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Mia!

@miagilepner miagilepner merged commit 4f32443 into main Jan 7, 2025
89 of 92 checks passed
@miagilepner miagilepner deleted the miagilepner/flaky-fixes branch January 7, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants