Vault 27421 update cap/ldap dep #29302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
fairclothjm
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Thanks! Can we also update cap/ldap in the sdk's go.mod?
Line 18 in e153846
helenfufu
changed the title
helenfufu
commented
Jan 7, 2025
changelog/29302.txt
Outdated
Comment on lines
1
to
3
| ```release-note:change | ||
| cap/ldap: Upgrade cap/ldap to https://github.com/hashicorp/cap/commit/9047b8b3240fd6503b08a05e5a5455793c64100f, which includes a security improvement to ensure that user DN searches with `upndomain` configured will check that exactly one user is returned and error otherwise. | ||
| ``` |
There was a problem hiding this comment.
Would appreciate guidance here:
- Is it alright to link the exact commit, or would it be preferred to mention something along the lines of "latest commit on main"?
- Does this level of detail about the security improvement need to be documented in the changelog in addition to the upgrade guide? Wasn't sure if it was redundant to have it here as well.
There was a problem hiding this comment.
I think for the changelog, we should not reference cap/ldap but instead auth/ldap and any anywhere else this may have effect. I think that is the only one though. We want changelogs to describe the effect on the Vault user. So in this case, something like (I believe the effect is on login?):
release-note:change
auth/ldap: An error will now be returned on login if the number of entries returned from the user DN LDAP search is more than one.
There was a problem hiding this comment.
I see, thanks for explaining 🙏
fairclothjm
previously approved these changes
Jan 7, 2025
fairclothjm
approved these changes
Jan 8, 2025
jonathanfrappier
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
github.com/hashicorp/cap/ldapdependency to the latest commit, currently hashicorp/cap@9047b8b, to address a low-severity security gap related to LDAP user search withupndomain. For more details, see the relatedcapPR: hashicorp/cap#151.Since this introduces a potential breaking change, it should not be backported to earlier Vault versions.
Ticket: VAULT-27421
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.