-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all pki-verification calls from sdk-Verify() to pki-specific #29342
Move all pki-verification calls from sdk-Verify() to pki-specific #29342
Conversation
CI Results: |
5fb330b
to
a9b832d
Compare
Build Results: |
b09467e
to
242fd3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, just need to clean up the moved function.
VerifyCertifcate(...); update sdk-Verify to allow multiple chains, but validate that at least one of those chains is valid.
…gle key parses (test fixes).
b43fa3b
to
99b3e3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞 There are no more base branch conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
VerifyCertifcate(...); update sdk-Verify to allow multiple chains, but validate that at least one of those chains is valid.
Description
This updates the "Verify" call in the SDK to allow multiple chains, but do more enforcement to check that at least one of those chains is valid.
--
builtin/logical/database/credentials.go ; line 269
--
physical/cassandra/cassandra.go ; line 201
--
plugins/database/influxdb/connection_producer.go ; line 97
This also updates calls inside the PKI secrets engine to use the configurable VerifyCertificate call rather than the sdk-version which lacks the context that Verify includes.
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
-- This doesn't change the signature of any function.
in the PR description, commit message, or branch name.