Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of sdk: updating to docker v27.2.1 into release/1.18.x #29360

Open
wants to merge 2 commits into
base: release/1.18.x
Choose a base branch
from

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #28456 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@tvoran
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Updates vault/sdk (and vault) to use docker v27.2.1.

Steps:

pushd sdk
go get github.com/hashicorp/go-secure-stdlib/plugincontainer@latest 
go mod tidy
popd
go get github.com/ory/dockertest@latest \                                                  
  github.com/moby/sys/user@latest \
  github.com/docker/[email protected] \
  github.com/hashicorp/[email protected]
go mod tidy

TODO only if you're a HashiCorp employee

  • [-] Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • [-] If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • [-] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • [-] RFC: If this change has an associated RFC, please link it in the description.
  • [-] ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 15, 2025
Copy link

hashicorp-cla-app bot commented Jan 15, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

github-actions bot commented Jan 15, 2025

CI Results:
All Go tests succeeded! ✅

@mickael-hc mickael-hc marked this pull request as ready for review January 15, 2025 23:08
@mickael-hc mickael-hc added this to the triaged milestone Jan 15, 2025
@mickael-hc mickael-hc force-pushed the backport/VAULT-30850/sdk-update-docker/kindly-skilled-sheepdog branch from 45f9058 to 3b697a4 Compare January 15, 2025 23:09
Copy link

github-actions bot commented Jan 15, 2025

Build Results:
All builds succeeded! ✅

@mickael-hc mickael-hc force-pushed the backport/VAULT-30850/sdk-update-docker/kindly-skilled-sheepdog branch from 3b697a4 to 8d0e6ba Compare January 16, 2025 15:21
@mickael-hc mickael-hc force-pushed the backport/VAULT-30850/sdk-update-docker/kindly-skilled-sheepdog branch from 8d0e6ba to c3ca085 Compare January 16, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants