Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make proto #29385

Closed
wants to merge 1 commit into from
Closed

Fix make proto #29385

wants to merge 1 commit into from

Conversation

divyaac
Copy link
Contributor

@divyaac divyaac commented Jan 22, 2025

Description

Fix make proto

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@divyaac divyaac requested review from a team as code owners January 22, 2025 18:10
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 22, 2025
@mpalmi
Copy link
Contributor

mpalmi commented Jan 22, 2025

@divyaac #29359 is just waiting on a +1 from the cryptosec team.

@VioletHynes
Copy link
Contributor

VioletHynes commented Jan 22, 2025

I'd prefer we update the following line in the install external tools to match our Protobuf version. That way, the linter doesn't fail regularly:
e.g.

    - run: ./.github/scripts/retry-command.sh go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
      shell: bash

to

    - run: ./.github/scripts/retry-command.sh go install google.golang.org/protobuf/cmd/[email protected]
      shell: bash

Then, when we choose to update protobuf, we can update it here too. The related protobuf dependencies in the same location should get the same treatment.

If we did want to keep it as-is, which I personally don't think is a good pattern (dependencies should be locked during builds so that builds are reproducible), then we should also update the version of protobuf in go.mod to match.

Copy link

CI Results: failed ❌

Copy link

Build Results:
All builds succeeded! ✅

@divyaac
Copy link
Contributor Author

divyaac commented Jan 22, 2025

Going to close this in favor of #29359

@divyaac divyaac closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants