Prepare code base for Go 1.24 update. #29412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- t.Fatal(f) should not be called within a Go routine based on it's documentation and only from the main test's thread. - In 1.24 this seems to cause build failures
- Within 1.24 these now cause test builds to fail …" from go vet
stevendpclark
added
pr/no-changelog
pr/no-milestone
backport/ent/1.16.x+ent
github-actions
bot
added
the
hashicorp-contributed-pr
VioletHynes
approved these changes
Jan 24, 2025
|
CI Results: |
|
Build Results: |
6 tasks
stevendpclark
added
backport/ent/1.17.x+ent
stevendpclark
added a commit
that referenced
this pull request
Jan 31, 2025
* Fix "t.Fatal from a non-test goroutine" errors in cache_test.go - t.Fatal(f) should not be called within a Go routine based on it's documentation and only from the main test's thread. - In 1.24 this seems to cause build failures * Address all "non-constant format string errors" from go vet - Within 1.24 these now cause test builds to fail …" from go vet Co-authored-by: Steven Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prepare the code base for a future Go 1.24 update when it is released.
There are a few issues that have become failures in 1.24, mainly passing in constant strings into methods that expect format arguments such as Fatalf, Sprintf. The second is calling t.Fatal from outside the main test go routine.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.