Streaming perf improv #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* flow control was assuming a `Read` consumed the entire buffer * flow control fix reduces memory utilization when receiving large streams of data * use timer pool to reduce allocations * use static handler function pointer to avoid closure allocations for every frame
stream.go
Outdated
| @@ -414,7 +423,7 @@ func (s *Stream) readData(hdr header, flags uint16, conn io.Reader) error { | |||
| } | |||
|
|
|||
| // Decrement the receive window | |||
| atomic.AddUint32(&s.recvWindow, ^uint32(length-1)) | |||
| s.recvWindow += ^uint32(length - 1) | |||
There was a problem hiding this comment.
Whilst it is the same thing, this is a carry over from the atomic operation. We should change this to read
s.recvWindow -= length
|
Did an offline code review with @dadgar to merge this. Thanks @stuartcarnie for the great work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created from PR #50