Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix quote color #1319

Merged
merged 2 commits into from
Jun 22, 2024
Merged

fix quote color #1319

merged 2 commits into from
Jun 22, 2024

Conversation

peterbecich
Copy link
Member

@peterbecich peterbecich commented Jun 22, 2024

closes: #1298

image

@peterbecich peterbecich force-pushed the fix-quote-color branch 2 times, most recently from 11298d2 to 526b7a9 Compare June 22, 2024 02:33
@peterbecich peterbecich marked this pull request as ready for review June 22, 2024 02:33
@peterbecich
Copy link
Member Author

@ffaf1 or @ysangkok, please review

@ysangkok
Copy link
Member

According to WebAIM, with the colors in the screenshot, foreground 21262F, background 281B35, the contrast is 1.06:1. I am not disabled and it's really faint for me. Of course, this isn't really foreground, and it shouldn't be too jarring, but this contrast is still really small. Another approach is too mark the quote by a line on the left, or maybe a 1em wide 45deg line pattern. I would be fine with a contrast of 1.5:1 or something like that. Using the lightness slider, that would mean replacing by 21262F by 49355F.

@peterbecich
Copy link
Member Author

Thanks, good point. The color is 252034 versus 333 but you're correct; the contrast is too low.

background-color: #252034;

https://webaim.org/resources/contrastchecker/?fcolor=252034&bcolor=333333

How about 4c4771 versus 333 https://webaim.org/resources/contrastchecker/?fcolor=4C4771&bcolor=333333

image

@peterbecich peterbecich merged commit 4d5aebe into haskell:master Jun 22, 2024
11 checks passed
@peterbecich peterbecich deleted the fix-quote-color branch June 22, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quotes have very inaccessible / illegible styling
2 participants