gracefully handle errors for unsupported cabal version #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridewald
commented
Oct 12, 2024
fridewald
force-pushed
the
4401/gracfully_handle_errors_for_unsupported_cable_version
branch
from
c8db13a to
1116c31
Compare
fendor
changed the title
fridewald
changed the title
fridewald
force-pushed
the
4401/gracfully_handle_errors_for_unsupported_cable_version
branch
2 times, most recently
from
295dcb8 to
40173f4
Compare
fendor
changed the title
fendor
approved these changes
Oct 15, 2024
|
Sorry for not responding, and thanks for adding the last missing change! |
|
No worries, it is usually no hurry, but we likely will have a release soon, I would love to have this change in :) So rather, my apologies for just pushing changes without asking! |
fendor
force-pushed
the
4401/gracfully_handle_errors_for_unsupported_cable_version
branch
from
b543998 to
12cbc38
Compare
Signed-off-by: Julian Kalema Lukwata <[email protected]>
fendor
force-pushed
the
4401/gracfully_handle_errors_for_unsupported_cable_version
branch
from
12cbc38 to
869e8a3
Compare
fridewald
deleted the
4401/gracfully_handle_errors_for_unsupported_cable_version
branch
noughtmare
pushed a commit
to noughtmare/haskell-language-server
that referenced
this pull request
Oct 23, 2024
* Safely handle linenumbering for errors in the first line of cabal files * add integration test for unsupported cabal version Signed-off-by: Julian Kalema Lukwata <[email protected]> * cast unsupported cabal version as warning * add better warning text * Add supported cabal-versions to the error message --------- Signed-off-by: Julian Kalema Lukwata <[email protected]> Co-authored-by: Fendor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that line number 0 returned from cabal is handled correctly.
This caused the marking of the whole cabal file if the cabal version is not supported as described in #4401