Make Proxy and Funnel port configurable

[lmagyar]

Proposed Changes

Also made the port configurable. Proxy and Funnel are using the same port, so making 2 port configs and dropping the current proxy: bool? and funnel: bool? configs can't be done. So 443 by default is configured as port, but this won't start proxy or funnel automatically.

Related Issues

fixes #276

[lmagyar]

Finally moved all non port related code into the #273 PR, because now it's much clearer which service and PR does what.
Now both are ready to review.

[lmagyar]

Rebased it, and ready to review.

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

[lmagyar]

Not stale, decision is to be made:

• move this option from port config to plain config like proxy_and_funnel_port: port? (because this is not a real host port, it is available only in the tailnet)
• or forget it in favor of PR Use new tailscale cli arguments and merge proxy and funnel into longrun serve service #306 (which allows using the cli for serve config, but I think it is a big step for an average user to use command line to configure a basic thing like a port, so I prefer to move this option to a plain option and leave advanced command line for more experienced users)

[frenck]

I actually think we need to move this to an add-on option, which also allows us to guard that the port number is in one of the accepted ones.

I feel like this is a bit too much abusing a port feature that was not meant for this usecase (and allows for any port, even if it doesn't make sense).

../Frenck

[frenck]

which allows using the cli for serve config

We should never expose that.

[lmagyar]

I've used proxy_and_funnel_port: list(443|8443|10000)? option to configure it.

Issues:

• This limits the port number to this 3, even when only Proxy (tailscale serve) is used, though this is a Funnel restriction. But I think this will cause less complaints than enabling any port for Proxy that runs on to error when the user later enables Funnel.
• The generated YAML configuration looks a bit ugly for an integer port number: proxy_and_funnel_port: "8443"
• If the user edit the YAML and enters proxy_and_funnel_port: "8443" the UI will not give an error, but the non-YAML view can't select the right "8443" from the list. The add-on works certainly. This seems to be a UI bug around int/str values.

Otherwise ready to review.

[frenck]

Hmm right, the list is considered a list of strings by the SU.

[frenck]

Let's see how it behaves. Thanks, @lmagyar 👍

../Frenck

[lmagyar]

Wait, wait!

We can use a regex!

[lmagyar]

Give me a few minutes to test it.