Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change daily updates to hourly updates #355

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Change daily updates to hourly updates #355

merged 4 commits into from
Nov 10, 2023

Conversation

TobiasNx
Copy link

@TobiasNx TobiasNx commented Oct 10, 2023 •
edited by dr0i
Loading

See #350.

@TobiasNx TobiasNx requested a review from dr0i October 10, 2023 11:37
@dr0i dr0i force-pushed the 350-reduceIntervalSizeForUpdates branch 3 times, most recently from 48dd18c to 5198bc8 Compare November 9, 2023 15:20
@dr0i dr0i force-pushed the 350-reduceIntervalSizeForUpdates branch from 5198bc8 to 4ae5366 Compare November 9, 2023 15:21
dr0i added 2 commits November 10, 2023 11:22
@dr0i
Set "from" always minus 1 minute (#350)
6484cdd 
This follows the recommendation of the DNB. This enables a bit of overlapping
to ensure to get all the data.

See #350 (comment).
@dr0i
Improve documentation (#350)
f6fc433
@dr0i dr0i marked this pull request as ready for review November 10, 2023 10:36
@dr0i dr0i requested review from fsteeg and removed request for dr0i November 10, 2023 10:36
@dr0i dr0i mentioned this pull request Nov 10, 2023
Closed
@fsteeg fsteeg removed their assignment Nov 10, 2023
@dr0i
Copy link
Member

dr0i commented Nov 10, 2023

Tested the branch, looks good:

[info] Running apps.ConvertUpdates 2023-11-10T08:44:20Z
Trying to get data using http://$pipapo/oai/repository from 2023-11-10T08:44:20Z until 2023-11-10T12:47:30Z using a 1 days interval , i.e. doing 1 lookup(s)
Calling OAI-PMH at http://$pipapo/oai/repository from 2023-11-10T08:43:20Z until 2023-11-10T12:47:30Z
resumptionToken:
resumptionToken: hNBAeNpNjEsKgDAMBU_S3EDIq6ZN9uIBvIGLgoIiaAWP7xfx7eYxDIJZQNAycixdWzf7NFK35X5ehjyklRoSJlwWi_K1hzxXwmZG7m_jzQk-8SblqAhyPkBMooWvEoHU2wFo7B-L
....

Not that it's crucial to initially set the date time in GND-lastSuccessfulUpdate.txt to the new format.

@dr0i dr0i assigned fsteeg and unassigned dr0i Nov 10, 2023
@fsteeg fsteeg assigned dr0i and unassigned fsteeg Nov 10, 2023
@dr0i dr0i merged commit 48f0c8c into master Nov 10, 2023
@dr0i dr0i deleted the 350-reduceIntervalSizeForUpdates branch November 10, 2023 13:47
@dr0i dr0i mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsteeg fsteeg fsteeg approved these changes

Assignees

@dr0i dr0i

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TobiasNx @dr0i @fsteeg