Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate "dateCreated" #2124

Open
dr0i opened this issue Jan 14, 2025 · 1 comment
Open

Validate "dateCreated" #2124

dr0i opened this issue Jan 14, 2025 · 1 comment
Assignees
@TobiasNx

Comments

@dr0i
Copy link
Member

dr0i commented Jan 14, 2025 •
edited
Loading

3969 documents have an invalid date value. These could be validated with a regex and, if invalid, be substituted with a default/fallback value, say the date of ETL processing.
See e.g.:

[902]: index [resources-alma-fix-20250113-1418], type [resource], id [99373737680006441], message [MapperParsingException[failed to parse [describedBy.resultOf.object.dateCreated]]; nested: IllegalArgumentException[Cannot parse "2019-78-06": Value 78 for monthOfYear must be in the range [1,12]];]
@dr0i dr0i moved this from Backlog to Ready in lobid-resources Jan 14, 2025
TobiasNx added a commit that referenced this issue Jan 14, 2025
@TobiasNx
Add testfile 99373737680006441 #2124
ed98df3
TobiasNx added a commit that referenced this issue Jan 14, 2025
@TobiasNx
Use regex for validating dateCreated #2124
62a8feb 
The regex checks for correct possible month and day digits, but does not check if a month has 30 oder 31 days.
TobiasNx added a commit that referenced this issue Jan 14, 2025
@TobiasNx
Update web tests #2124
b0d287e
@TobiasNx TobiasNx mentioned this issue Jan 14, 2025
Merged
@dr0i
Copy link
Member Author

dr0i commented Jan 16, 2025

To be checked next Monday.

@dr0i dr0i moved this from Ready to Review in lobid-resources Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TobiasNx TobiasNx

Labels
None yet
Projects
lobid-resources
Status: Review
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dr0i @TobiasNx