2124-validateDateCreated #2125
Merged
2124-validateDateCreated #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex checks for correct possible month and day digits, but does not check if a month has 30 oder 31 days.
|
@dr0i can you check this? |
dr0i
approved these changes
Jan 16, 2025
As suggested by reviewer Co-authored-by: Pascal Christoph <[email protected]>
As suggested by reviewer Co-authored-by: Pascal Christoph <[email protected]>
|
+1 I applied these. @dr0i you can merge these. |
|
Be deployed next Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2124
The regex checks for correct possible month and day digits, but does not check if a month has 30 oder 31 days.