Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm Reach Visualization and THREE.js setup #31

Merged
merged 14 commits into from
Jul 9, 2021

Conversation

kavidey
Copy link
Collaborator

@kavidey kavidey commented Jul 5, 2021

Merge arm reach visualization changes into the master branch.

@kavidey
Copy link
Collaborator Author

kavidey commented Jul 5, 2021

Most of the merge here is pretty simple, the big updates just have to be made to operator_ui_regions.js, because none of the three.js code is object-oriented.

I'm working on transitioning the current Overlay class to a parent class, and then creating child OverlaySVG and OverlayTHREE classes so that both svg regions and threejs scenes integrate well with the VideoControl system. I also switched the classes over to ES6 class syntax for cleanliness.

@kavidey kavidey linked an issue Jul 5, 2021 that may be closed by this pull request
@kavidey kavidey self-assigned this Jul 6, 2021
@kavidey
Copy link
Collaborator Author

kavidey commented Jul 6, 2021

@mayacakmak Everything should be merged into the new interface. I'm working on testing different features in simulation, but they should probably also be tested on the robot before merging into master.

Some things I've already noticed:

  • When the manipulation interface is selected, should the reach overlay circle disappear with the region outlines? Currently it does, but I can also keep it visible and just greyed out like the video feed.
  • There is a lot of errors coming from the effort overlays. I think this is caused by references to non-existent region id's that were changed/removed in the split screen interface
  • The whole interface feels a bit sluggish, I'm not sure if this is caused by the three.js rendering or something else, but we may want to take a pass through and try to optimize things

@mayacakmak
Copy link

mayacakmak commented Jul 7, 2021

Excellent! I will test this in that branch on the real robot before merging onto master.

  • I think it makes sense for it to disappear during manipulation mode. Let's keep it this way and see if situations come up where it would be good to have it during manipulation.
  • Let me see about the sluggishness when I test on the robot.
  • Yes, effort overlays are not fully working and you are completely right about the likely reason--feel free to fix this if you already know what to do, it's on my list of issues to address based on Vy and Elliston's tests. BTW we also need to find a way to visualize the feedback for the gripper effort, I was thinking either we change the button color towards red or we bring the gripper controls back onto the overlay (it's getting a bit crammed but Henry has not expressed any concerns about that)
  • This makes me think we should have a checkbox in the settings for something like 'Visualize arm reach in navigation view' which can completely remove the visualization, so it is optional. It might be irrelevant for some tasks and the user should be able to disable it.

thanks!

@mayacakmak
Copy link

For some reason I'm unable to check out this branch as usual (perhaps something to do with the branch name starting with a "#"?) I'll go ahead and merge and test on master but let me know if you know why that might be @kaviMD, thanks!

@mayacakmak mayacakmak merged commit 40b6a34 into master Jul 9, 2021
@nickswalker nickswalker deleted the #11-decrease-manipulation-burden branch December 2, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualize arm reach during drive mode
2 participants