Updated to 1.2.1 and dealt with issue 50 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Grezzo
commented
Dec 7, 2014
Grezzo
commented
- Fix for issue case sensitive file system problem, creating VagrantFile not Vagrantfile #50
- Updated to Tail 1.2.1
- Added tested model from case sensitive file system problem, creating VagrantFile not Vagrantfile #50
added 3 commits
December 7, 2014 21:32
Despite https://docs.vagrantup.com/v2/vagrantfile/ stating that "casing doesn't matter", the issue at #50 suggests otherwise. I also reproduced this by using a case sensitive formatted disk image and was able to test the fix this way. I also created an issue on the vagrant github for this bug too: hashicorp/vagrant#4907
1.2 was no longer available for download. Changed links to get v1.2.1
Added MacBook Pro 8,1 from #50
|
No, the problem was that if you have a case sensitive file system, the The fix for issue 50 was simply to rename the file so that the f was lower case I'm fairly new to github, should I have submitted separate pull requests for each change, or is it OK to lump them all together like this? |
Previously .gitignore would have been deleted, and the files were temporarily moved which was not ideal. Now nothing is moved and everything in the data folder except the BOOTX64.efi and .gitignore file are deleted.
|
Ah ok sorry I missed that. No it's good to submit PR's like this. Thanks for the clarification. |
hellais
added a commit
that referenced
this pull request
Dec 10, 2014
Updated to 1.2.1 and dealt with issue 50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.