Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't setup worktree if not packaging for git #486

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

chriswiggins
Copy link
Contributor

In #314 , the functionality to push to the pages branch was moved outside the loop, which meant that the worktree was being set up, even if it wasn't required.

This causes issues for us as we don't use gh-pages (private repo) - so this moves the AddWorktree into a check

@chriswiggins chriswiggins force-pushed the fix/package-with-index branch from 773df39 to f0860bd Compare January 21, 2025 20:05
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

i will cut a patch release soon

@cpanato cpanato merged commit 5398fb7 into helm:main Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants