fix: rename wrapper to tab wrapper #4636
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 6ec9d40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe pull request introduces a minor update to the tabs component across multiple files. The primary change involves renaming the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/dull-ladybugs-whisper.md (1)
4-5: Improve the commit message format.The commit message could be clearer and follow conventional commit format better.
Consider this improved format:
-Fix tabs slots "tab" rename to "tabWrapper" -- Breaking Change (#4552) +feat!: rename tabs slot from "tab" to "tabWrapper" (#4552) + +BREAKING CHANGE: The "tab" slot has been renamed to "tabWrapper" for better clarity +and consistency with other wrapper implementations.This format:
- Uses the conventional commits prefix with
!to indicate breaking change- Adds a blank line after the title
- Includes a clear BREAKING CHANGE note
- Provides context for the change
🧰 Tools
🪛 LanguageTool
[uncategorized] ~5-~5: This verb may not be in the correct tense. Consider changing the tense to fit the context better.
Context: ...theme": patch --- Fix tabs slots "tab" rename to "tabWrapper" -- Breaking Change (#45...(AI_EN_LECTOR_REPLACEMENT_VERB_TENSE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.changeset/dull-ladybugs-whisper.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
.changeset/dull-ladybugs-whisper.md
[uncategorized] ~5-~5: This verb may not be in the correct tense. Consider changing the tense to fit the context better.
Context: ...theme": patch --- Fix tabs slots "tab" rename to "tabWrapper" -- Breaking Change (#45...
(AI_EN_LECTOR_REPLACEMENT_VERB_TENSE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build
There was a problem hiding this comment.
@winchesHe I'm a bit confused. This PR includes two renames. Can you double check if they are expected?
tab->tabWrapperwrapper->tabWrapper
tab will be still here in tabs tv while wrapper will not.
updated |
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
.changeset/dull-ladybugs-whisper.md (1)
1-3:⚠️ Potential issueVersion bump should be major for breaking changes.
The changeset indicates a patch version bump, but the commit message mentions this is a breaking change. According to semver, breaking changes should increment the major version.
Apply this diff to update the version bump:
--- -"@heroui/theme": patch +"@heroui/theme": major ---
🧹 Nitpick comments (1)
.changeset/dull-ladybugs-whisper.md (1)
5-5: Improve commit message format.The commit message should use the past tense to describe what the change accomplished.
Apply this diff to improve the commit message:
-Fix tabs slots "wrapper" rename to "tabWrapper" -- Breaking Change (#4552) +Fixed tabs slots by renaming "wrapper" to "tabWrapper" -- Breaking Change (#4552)🧰 Tools
🪛 LanguageTool
[uncategorized] ~5-~5: This verb may not be in the correct tense. Consider changing the tense to fit the context better.
Context: ...e": patch --- Fix tabs slots "wrapper" rename to "tabWrapper" -- Breaking Change (#45...(AI_EN_LECTOR_REPLACEMENT_VERB_TENSE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/dull-ladybugs-whisper.md(1 hunks)apps/docs/content/docs/components/tabs.mdx(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/docs/content/docs/components/tabs.mdx
🧰 Additional context used
🪛 LanguageTool
.changeset/dull-ladybugs-whisper.md
[uncategorized] ~5-~5: This verb may not be in the correct tense. Consider changing the tense to fit the context better.
Context: ...e": patch --- Fix tabs slots "wrapper" rename to "tabWrapper" -- Breaking Change (#45...
(AI_EN_LECTOR_REPLACEMENT_VERB_TENSE)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: TypeScript
- GitHub Check: Build
Closes #4552
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
wrapperwill be renamed totabWrapper📝 Additional Information
Summary by CodeRabbit
Summary by CodeRabbit
Bug Fixes
Chores
@heroui/themeDocumentation
Tabscomponent to reflect the renaming of the tab wrapper slot and updated type definitions.These changes enhance consistency in the naming of tab wrapper slots while preserving the overall functionality of the tabs component.