-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workerpool): bring up #212
Conversation
Minimum required Node.js version has bumped to 12.13, which is the first LTS version of Node.js 12: https://nodejs.org/en/blog/release/v12.13.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mergeable after removing unneeded eslint-disable-line.
@@ -0,0 +1,23 @@ | |||
'use strict'; | |||
|
|||
// eslint-disable-next-line node/no-unsupported-features/node-builtins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not required after https://github.com/hexojs/hexo-util/pull/212/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R57
comment in other files can be removed too.
@curbengh We might not bring up Worker Threads during Hexo 5.0.0 development. So we can leave this PR here until we officially drop Node.js 12. |
Any updates on this thread? |
After some benchmarking, multi-thread could actually hurt the performance for most of the hexo site, as serializing objects between the main thread and the worker thread would introduce too much overhead. |
There are already many worker pool implementations out there that are better than my home-baked one. Even if Hexo is going to adapt multi-thread, we will use those libraries instead. |
The PR is a part of hexojs/hexo#4355.
Bring up a utility to manage workers and job queue.