Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(backtick_code): replace cloneDeep with Object.assign() #3826

Merged
merged 1 commit into from
Nov 8, 2019
Merged

refactor(backtick_code): replace cloneDeep with Object.assign() #3826

merged 1 commit into from
Nov 8, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Nov 2, 2019

What does it do?

Part of #3753

How to test

git clone -b refactor-clonedeep https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.141% when pulling 12a43ef on curbengh:refactor-clonedeep into b2a71e7 on hexojs:master.

seaoak
seaoak approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@seaoak seaoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since the target is a plain JavaScript object.

@SukkaW SukkaW merged commit 1b69a53 into hexojs:master Nov 8, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

@seaoak seaoak seaoak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curbengh @coveralls @seaoak @SukkaW