Allow overriding landscape theme sidebar config #4723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Landscape provides a fully loaded config, there is no clean way to get a minimal config without **hard** forking the theme. This allows a cleaner way over overriding theme configs. In most inheritance models, class methods are fully superseded by the extending class, pyYaml supports this model. Alternatively we could use a database migration model, where the config has a theme version and schema version and merges are done based on that. This PR just works with the present situation.
|
It's clear this isn't enough. What's needed is a major update full of hooks and a two tier theme yml. One one internal and override-discouraged, one external and fully override able. As well as hooks for late-cascade scss styles. Same for a JavaScript module hook or 10. Forking is always worse than override-able thing we can provide. |
|
We need to update the default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landscape provides a fully loaded config, there is no clean way to get a minimal config without hard forking the theme.
This allows a cleaner way over overriding theme configs.
#3890
#4154
hexojs/hexo-theme-landscape#102
In most inheritance models, class methods are fully superseded by the extending class, pyYaml supports this model.
Alternatively we could use a database migration model, where the config has a theme version and schema version and merges are done based on that.
This PR just works with the present situation.
How to test
Pull request tasks