Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gitHook): add multiple platform support #5279

Closed
wants to merge 4 commits into from

Conversation

dimaslanjaka
Copy link
Contributor

@dimaslanjaka dimaslanjaka commented Aug 25, 2023

What does it do?

update git hook pre-commit for multiple platforms

  • add cygwin support (tested on windows 10 latest cygwin version)
  • add WSL support (tested on windows 10 WSL ubuntu)
  • add windows cmd support (tested commit on windows 10 cmd)

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

- add cygwin support
- add WSL support
- add windows cmd support
@github-actions
Copy link

How to test

git clone -b update-githook https://github.com/dimaslanjaka/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

coveralls commented Aug 25, 2023

Coverage Status

coverage: 99.529%. remained the same when pulling 1856017 on dimaslanjaka:update-githook into 24a7b61 on hexojs:v7.0.0.

@stevenjoezhang stevenjoezhang changed the base branch from v7.0.0 to master October 25, 2023 05:01
@uiolee
Copy link
Member

uiolee commented Dec 22, 2023

I am running pre-commit fine in git-bash and wsl. I guess this isn't necessary. And it makes the code complicated.

@uiolee uiolee closed this Dec 22, 2023
@dimaslanjaka dimaslanjaka deleted the update-githook branch February 14, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants