Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(external_link): optimize external link filter #5598

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

D-Sketon
Copy link
Member

What does it do?

optimize externalLinkFilter

Screenshots

before
{201CA726-9041-405D-9EF2-D668880F3817}
after
{34EFB4B8-DB50-4B84-A750-817737F6A2A2}

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Copy link

How to test

git clone -b perf/externalLinkFilter https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test

@SukkaW
Copy link
Member

SukkaW commented Jan 2, 2025

@D-Sketon BTW We can probably find more similar patterns in Hexo's codebase that can also be refactored.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12654113964

Details

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.482%

Totals Coverage Status
Change from base Build 12654056940: 0.001%
Covered Lines: 9410
Relevant Lines: 9459

💛 - Coveralls

@uiolee uiolee merged commit 6f74e6c into hexojs:master Jan 9, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants