Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sha256 to OTP builds.txt #188

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

gigatim
Copy link
Contributor

@gigatim gigatim commented May 16, 2024

This PR adds a sha256 to the builds.txt files for OTP.

Background

PR #34 added sha256 to the elixir builds.txt This comment called out that a separate PR should be created to do the same to the OTP builds.txt file. It appears this was never completed.

Also relates to #16

Test Disclaimer

I was not able to run it locally. Therefore the PR is provided without any testing at all.

@gigatim
Copy link
Contributor Author

gigatim commented Jun 9, 2024

@ericmj Can I get a review on this PR? I do not have the permissions to request a reviewer in the GitHub UI.

priv/scripts/otp/otp.sh Show resolved Hide resolved
@wojtekmach wojtekmach force-pushed the main branch 2 times, most recently from f03ce04 to 1c88d85 Compare August 2, 2024 19:24
@gigatim
Copy link
Contributor Author

gigatim commented Aug 9, 2024

@wojtekmach do you have an ETA on when this might get merged into main/production?

@wojtekmach
Copy link
Member

Before merging this, I think we should have a script ready that updates all existing builds.txt with the checksums. WDYT @ericmj?

These are all the files we need to update:

$ for arch in amd64 arm64; do for os in ubuntu-{20.04,22.04,24.04}; do echo https://builds.hex.pm/builds/otp/$arch/$os/builds.txt; done ; done
https://builds.hex.pm/builds/otp/amd64/ubuntu-20.04/builds.txt
https://builds.hex.pm/builds/otp/amd64/ubuntu-22.04/builds.txt
https://builds.hex.pm/builds/otp/amd64/ubuntu-24.04/builds.txt
https://builds.hex.pm/builds/otp/arm64/ubuntu-20.04/builds.txt
https://builds.hex.pm/builds/otp/arm64/ubuntu-22.04/builds.txt
https://builds.hex.pm/builds/otp/arm64/ubuntu-24.04/builds.txt

@gigatim
Copy link
Contributor Author

gigatim commented Aug 21, 2024

Before merging this, I think we should have a script ready that updates all existing builds.txt with the checksums. WDYT

I disagree. This is adding additional meta data, which does not necessarily need to be retroactively added. I'm not opposed to having older versions updated, but I don't know that this PR should be blocked on that work.

For instance, the https://builds.hex.pm/builds/elixir/builds.txt only has this additional field on some (newer) lines.

@wojtekmach wojtekmach merged commit 4981d44 into hexpm:main Sep 11, 2024
2 checks passed
@wojtekmach
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants