Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add createMutationQuery method that accept criterias #2094

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Add createMutationQuery method that accept criterias #2094

merged 5 commits into from
Feb 3, 2025

Conversation

dreab8
Copy link
Member

@dreab8 dreab8 commented Jan 30, 2025 •
edited by DavideD
Loading

Fix #1885

@dreab8 dreab8 requested a review from DavideD January 30, 2025 16:31
@dreab8 dreab8 force-pushed the HREACT_29_4 branch 2 times, most recently from ac6ce78 to 1908f66 Compare January 31, 2025 10:22
gavinking
gavinking requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should always avoid the unnecessary use of raw types.

hibernate-reactive-core/src/main/java/org/hibernate/reactive/mutiny/Mutiny.java Outdated Show resolved Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/mutiny/Mutiny.java Outdated Show resolved Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/mutiny/Mutiny.java Outdated Show resolved Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/stage/Stage.java Outdated Show resolved Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/stage/Stage.java Outdated Show resolved Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/stage/Stage.java Outdated Show resolved Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/stage/Stage.java Outdated Show resolved Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/stage/Stage.java Outdated Show resolved Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/stage/Stage.java Outdated Show resolved Hide resolved
@gavinking
Copy link
Member

gavinking commented Jan 31, 2025 •
edited
Loading

@dreab8 Why did you add type parameters instead of using my suggestions with wildcarded types?

@dreab8
Copy link
Member Author

dreab8 commented Jan 31, 2025 •
edited
Loading

I noticed the other methods are using the same approach, is it wrong?

@gavinking
Copy link
Member

I noticed the other methods are using the same approach, is it wrong?

Well the other methods return Query<T>, so the type of the parameter is correlated with the return type.

But for these methods there is no such correlation, and so it's simpler and clearer to just use a wildcard.

@dreab8
Copy link
Member Author

dreab8 commented Jan 31, 2025

thanks for the explanation, I'm going to remove the type parameters and use the wildcard types

@DavideD DavideD merged commit d9cd9bf into hibernate:main Feb 3, 2025
19 checks passed
@DavideD
Copy link
Member

DavideD commented Feb 3, 2025

Merged, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideD DavideD DavideD left review comments

@gavinking gavinking gavinking requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add createMutationQuery method that accept criterias
3 participants
@dreab8 @gavinking @DavideD